THREESCALE-12316: Fix deserialization with legacy --- HashWithIndifferentAccess#4229
Open
THREESCALE-12316: Fix deserialization with legacy --- HashWithIndifferentAccess#4229
Conversation
❌ 3 blocking issues (3 total)
@qltysh one-click actions:
|
mayorova
force-pushed
the
fix-hash-deserialization
branch
from
f24de2c to
ad859cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
There are might be some records in the DB which have hashes serialized with a legacy prefix
!map:HashWithIndifferentAccess.Which issue(s) this PR fixes
https://issues.redhat.com/browse/THREESCALE-12316
Verification steps
A simple way is to modify the data directly in the DB. For example,
extra_fieldsincinstancestable. Example of legacy serialization:Before the fix in this PR trying to load such application will fail.
After the fix, the applications are loaded OK. After saving the application, the serialization class is updated in the DB.
Special notes for your reviewer: